Oliver Stöneberg
Oliver Stöneberg
Also occurs with workflows utilizing older docker images. See https://github.com/danmar/cppcheck/actions/runs/7677304162/job/20926809147?pr=5917 https://github.com/danmar/cppcheck/pull/5918
It also seems like this caused a major slowdown in the `Post ccache` step - it now takes way above 2 minutes instead of being of a few seconds: Before:...
I second to start a new version for this change and leave `v1.2` on Node 16. > Your 2nd problem: It ran slower, because it did not found a cache....
> Alright, I think here is what we should do: > > * revert the switch to node 20 back to 16 and release it as 1.2.13 with tags for...
Even with fixating to version `1.2.11` the two minute hang is now present because the underlying runners have all been updated to Node 20.
I get that, but I just added these because I need them. The overhead of `std::istream` is just not acceptable. I also stated in the other PR that I will...
> Taking a std::string would be better imho but I still feel that std::istream is better for type safety reasons. And as I said - if the string is not...
> I would be interested to know what that is however it should be done here in the end so why not start with that so we don't have to...
It is about core performance since simplecpp is supposed to be embedded. In Cppcheck as soon as the ValueFlow kicks in obviously nothing else matters... > But we are not...
> `std::vector` or `std::string` would be better than a C buffer and size. I do not know what problems you see with `std::string` that are solved by using a raw...