profiler

profiler copied to clipboard

ideas: * have a "per second" graph for some markers (toggled by the schema) * for these markers, clicking on the graph would display percentile histograms prior art from padenot...

julienw

When looking at markers for a merged thread, the thread shown in the tooltip is always "Merged Thread"

1

STR: 1. Open [this profile](https://profiler.firefox.com/public/36d6d200bb8ec4eff5a90044dc066063703edf6a/marker-chart/?globalTrackOrder=4-5-0-1-2-3&localTrackOrderByPid=39199-0~39202-0~39200-0~39201-0~&thread=3&v=5) 1. Shift click some threads. 1. Hover some markers => notice that the displayed thread is always "Merged Thread". Instead we should show the originating...

julienw

Currently we display markers sorted by their names. Instead we can try different things: * in each category, sort by time (use only one big "marker timing" chunk for each...

julienw

Implement Sticky Tooltips

1

See previous discussions: #1442 #1470 #1469 My proposal here is much less ambitious: being able to copy paste what's in a tooltip. To do this, I propose the following MVP:...

julienw

STR: 1. open a profile like [this one](https://profiler.firefox.com/public/z7jpz18p7e9j778mr0bccaj7nrejspqcxcbe1hg/calltree/?globalTrackOrder=0-1-2-3-4-5-6-7-8-9-10-11-12&hiddenGlobalTracks=0-1-2-3-4-5-6-7-8-9-10-11&hiddenLocalTracksByPid=12209-0&localTrackOrderByPid=12111-51-52-0-1-2-3-4-5-6-7-8-9-10-11-12-13-14-15-16-17-18-19-20-21-22-23-24-25-26-27-28-29-30-31-32-33-34-35-36-37-38-39-40-41-42-43-44-45-46-47-48-49-50~12638-0~12150-0~12500-0~12440-0~12257-0~12286-0~12270-0~12265-0-1~12261-0-1~12254-0-1~12279-0~12209-0~&thread=63&timelineType=cpu-category&v=5) 1. resize the window (for example by opening devtools on the right) => see how hit testing reacts weirdly ┆Issue is synchronized...

julienw

In a recent PR (https://github.com/firefox-devtools/profiler/pull/3308) I made the stack chart work for allocations data. However I noticed some issues: * the tooltip still shows timing data -- I'm not even...

julienw

In #3305 I disabled the new eslint test that checks when we use `container`. We do use `container` in tests for these cases: 1. snapshot tests 1. use of `querySelector`...

julienw

We're using floats as timestamps. This works well enough for big numbers, but this has a lot of imprecisions. This produces the following issues: * rounding errors for the marker...

julienw

Sanitizing the time range doesn't work in this profile

2

STR: 1. load this profile: https://share.firefox.dev/3sfuhfj 1. commit a new time range 1. upload with unchecking "include the hidden time range" => the hidden time range isn't removed I didn't...

julienw

We need a clever idea to localize `additionalMessage`: Currently this comes from various locations: * temporary errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/reducers/app.js#L27-L34 * fatal errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/components/app/AppViewRouter.js#L86-L91 Also `ProfileRootMessage` is used in different locations (`ProfileLoaderAnimation`...

julienw