profiler icon indicating copy to clipboard operation
profiler copied to clipboard
verified publisher icon firefox-devtools

Localize `additionalMessage` from `ProfileRootMessage`

Open julienw opened this issue 4 years ago • 0 comments

We need a clever idea to localize additionalMessage:

Currently this comes from various locations:

  • temporary errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/reducers/app.js#L27-L34
  • fatal errors: https://github.com/firefox-devtools/profiler/blob/df26770b5416f998e2dc40e0f11da787028272ad/src/components/app/AppViewRouter.js#L86-L91

Also ProfileRootMessage is used in different locations (ProfileLoaderAnimation and AppViewRouter), as is ProfileLoaderAnimation (both UrlManager and AppViewRouter). Probably we should simplify this, because currently it's quite difficult to understand which flow is used in which situation.

┆Issue is synchronized with this Jira Task

julienw avatar Mar 22 '21 13:03 julienw