firebase-unity-sdk icon indicating copy to clipboard operation
firebase-unity-sdk copied to clipboard

Add a test for whether unregistered listeners are called.

Open jonsimantov opened this issue 2 years ago • 1 comments

Description

Provide details of the change, and generalize the change in the PR title above.

Currently, if you unregister a listener from a given DatabaseReference, it will correctly stop calling that listener.

But if you unregister a listener from a different instance of DatabaseReference that happens to point to the same path, it will continue to call the listener. (Because it's not considered the same object.)

This test shows that issue - it should not be merged unless the issue is either fixed or the failing test is disabled.


Testing

Describe how you've tested these changes.

Integration tests.


Type of Change

Place an x the applicable box:

  • [ ] Bug fix. Add the issue # below if applicable.
  • [ ] New feature. A non-breaking change which adds functionality.
  • [ ] Other, such as a build process or documentation change.

jonsimantov avatar Feb 01 '23 20:02 jonsimantov

❌  Integration test FAILED

Requested by @jonsimantov on commit refs/pull/618/merge Last updated: Wed Feb 1 13:20 PST 2023 View integration test log & download artifacts

Failures Configs
database [TEST] [FAILURE] [2020] [All 2 Build OS(s)] [All 6 Platform(s)] [All 3 Test Device(s)]

github-actions[bot] avatar Feb 01 '23 20:02 github-actions[bot]