firelight

Results 94 comments of firelight

It is indeed very jank, but I guess it is better than what we have at the moment. Discord storing ids instead of views 😔

I believe this is best done in the viewmodel as otherwise the views will recycle when scrolling or switching the episode ranges ect.

This is quite a big PR, and looks like to actively developed so I will leave a detailed review and comment next week. If you have not already I would...

> > 3. I dont like that you store the selectedItems as VisualDownloadCached, use the Ids instead and a set to make duplication impossible > > I did have it...

> (and the other method also appears to have a bit worse performance?) I very much doubt that you get more than a ms of difference in performance. But yes,...

> I also still can't reproduce the bug that you had to delete twice? Can you provide exact steps that led to that circumstance? Like how many total downloads you...

I will investigate tomorrow and do another review.

1. The issue with deleted episodes still exists: ![image](https://github.com/user-attachments/assets/a9ba7fcc-afd8-44ea-998c-f1a93b9a7710) This is caused by safeFile reporting a failure to delete the file while the file is actually deleted (`val isFileDeleted =...

> I am not sure the best way to fix this, if you have any ideas it would be appreciated as well. I would consider the current prerelease to have...