cloudstream icon indicating copy to clipboard operation
cloudstream copied to clipboard

Fix cast recycler scrolling

Open Luna712 opened this issue 1 year ago • 5 comments

Fixes #563

Luna712 avatar Jul 28 '24 21:07 Luna712

This does not fix it completely, as it was still stuck after going to a recommendation, then pressing <-.

fire-light42 avatar Jul 28 '24 21:07 fire-light42

This does not fix it completely, as it was still stuck after going to a recommendation, then pressing <-.

Ah right will fix soon thanks!

Luna712 avatar Jul 28 '24 22:07 Luna712

@fire-light42 I fixed it as best I could. I think it works mostly but sometimes if you open recommendations and close it it takes a few seconds for cast recycler to work again or if you scroll up or down sometimes. Not 100% reliable but a lot better then it was (I think anyway)

Luna712 avatar Jul 28 '24 22:07 Luna712

@fire-light42 I fixed it as best I could. I think it works mostly but sometimes if you open recommendations and close it it takes a few seconds for cast recycler to work again or if you scroll up or down sometimes. Not 100% reliable but a lot better then it was (I think anyway)

If it is not 100% reliable, then you need to comment that in the code.

fire-light42 avatar Jul 28 '24 23:07 fire-light42

@fire-light42 I fixed it as best I could. I think it works mostly but sometimes if you open recommendations and close it it takes a few seconds for cast recycler to work again or if you scroll up or down sometimes. Not 100% reliable but a lot better then it was (I think anyway)

If it is not 100% reliable, then you need to comment that in the code.

@fire-light42

Thanks, I added a comment for that now.

Luna712 avatar Jul 28 '24 23:07 Luna712

It is indeed very jank, but I guess it is better than what we have at the moment. Discord storing ids instead of views 😔

fire-light42 avatar Jul 30 '24 18:07 fire-light42