Max Horn comments

Results 2041 comments of


                                            Max Horn

Ask the user whether they want to register a TNUM

That seems indeed rather advanced. It also only required editing the C file... So I am not convinced this is something that really needs to be added to PackageMaker...? But...

Rename the internal union `OneBasedRanges` to `_OneBasedRanges`

I like the trait idea by @LilithHafner but perhaps that's for a future PR?

Add forward progress update to NEWS.md

The sentence y'all were discussing about has in the meantime changed. It's not clear to me what the thoughts on the current phrasing are. Are people happy with it now?...

Set storage class of julia globals to dllimport on windows to avoid auto-import weirdness

Just to clarify: This PR targets the backports-release-1.10 branch. Does that means 1.11 and 1.12 are not affected? Or will they get separate fixes?

add helpful error to malformed `@test_throws` and `@test_warn`

@sjkelly ah, indeed, I agree

Avoid runtime dispatch in `similar` in broadcast

Adding a test to guard against regressions would indeed be nice, but if you don't have the bandwidth to create some, I think we should still merge it. I'll wait...

problem with `Hecke.math_html` for `nf_elem`

@thofma OK, so how would one use that to get the LaTeX Thomas is looking for?

problem with `Hecke.math_html` for `nf_elem`

For sin you could just use `\sin`, IIRC that's builtin. More generally `\mathrm{funcname}`. There is also \mathop but it is from a package. IIRC \operatorname is about spacing, though, isn't...

avoid an attribute value after leaving a break loop

I don't mind merging this, but as Chris wrote, in the end this is almost hopeless... Then again, if this is a case that is more frequently hit, we can...

`Cite` treats "The GAP Team" as the name of a person

If someone would like to add special handling for "The GAP Team", that'd be fine for me. Of course a more general solution would be nice, but I don't see...