Max Horn
Max Horn
Just to say, this functionality is already in `Oscar.jl` (and has been for some time), in `src/Groups/matrices/matrix_manipulation.jl`; this slipped past me in review, I only recently noticed it. Here's the...
Here's a theory why: code which calls `_zero_algebra` by definition cannot work (because there is no `_zero_algebra`). LLVM may then classify this code as having UB (undefined behavior) and that...
I can reproduce this in the REPL: ``` julia> A = matrix_algebra(GF(2), 2) Matrix algebra of dimension 4 over Prime field of characteristic 2 julia> @inferred Hecke._unit_group_generators(A) ERROR: return type...
Fascinating. With this patch, ``` E = elliptic_curve([1, 2, 3, 4, 5]) a, b = @inferred CPS_height_bounds(E) ``` fails because inside `CPS_height_bounds` the return type of `CPS_dvev_real` can no longer...
@lgoettgens thanks. Unfortunately that seems to be a dead end: ```julia code_warntype(Base.materialize, (Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{1}, Nothing, typeof(real), Tuple{Vector{AcbFieldElem}}}, )) ``` prints perfectly inferred information in both branches. I tried using `JET` but...
Hah, I just tried with Julia 1.11.0-rc2 and there it works (both Lars example and also the elliptic curve example). But it's not as if all was great: with that...
@lgoettgens with the move of stuff from Hecke to here, we are now at 122 reported cases of piracy :-(. Quit a lot of that hints at things which really...
While add it, maybe also add `convert` methods to/from `QQBar`? ``` convert(::Type{T}, x::QQBarFieldElem) where T
Also these should work (but don't) ``` QQBar(1//2) QQBarFieldElem(1//2) QQBarFieldElem(big(1)) # note that QQBar(big(1)) works ```
Conversion from ZZRingElem should also work (this just came up again while teaching with OSCAR)