フィルターペーパー
フィルターペーパー
@KarlK90 I had to make these [changes to retro_tapping/test_tapping.cpp](https://github.com/qmk/qmk_firmware/pull/17007/files#diff-4b81ab6267e32bf671729efaa23c6fb9283420208e8305f420861b97805afa9c) for the unit test to pass this PR. Does the parameter name `ANewTapWithinTappingTermIsBuggy` mean what it says?
> Do you intentionally avoid implementing an equivalent to ZMK's _global_ quick-tap because it is out-of-scope and in order to keep the PR small or is that planned in the...
`CONFIG_ZMK_IDLE_SLEEP_TIMEOUT` is millisecond unit while `CONFIG_ZMK_BATTERY_REPORT_INTERVAL` is in seconds. Aligning both might be helpful for consistency and comparison to set `CONFIG_ZMK_BATTERY_REPORT_INTERVAL` > `CONFIG_ZMK_IDLE_SLEEP_TIMEOUT`
> 2\. Unit-tests currently only test the old behavior, to verify the newly introduced timeout functionality it would be good to have at least two test cases that do a...
> The problem is that `is_tap_record` is called by generic tick events (row and col is 255) and not guarded against those. Normally this would result in out of bounds...
> I think the test conditions are wrong in the new unit-tests. Thanks for the pointers, hopefully all good now with the current revision.
> @filterpaper with the merge of #17281 this PR unfortunately has conflicts and needs a rebase. @KarlK90 Thanks for reviewing again, rebased as requested.
> @filterpaper you're rebase unfortunately doesn't contain the changes you did earlier to [`action_tapping.c`](https://github.com/filterpaper/qmk_firmware/blob/quick_tap_term/quantum/action_tapping.c#L173-L179) and some usages of `TAPPING_FORCE_HOLD` and `TAPPING_FORCE_HOLD_PER_KEY` sneaked into the code base in user code as...
Have you thought of using a different name or nomenclature like "instant tap" instead of "quick tap" to distinguish its functionality from the latter?
> @filterpaper, I did originally hope to use `min-prior-ms` to detach the concept from quick tap since it made a lot less sense for combos. However there was some discussion...