Filip Hrisafov

Results 837 comments of Filip Hrisafov

>@filiphr I meant that adding the properties doesn't change the behavior. Even with the properties I get a error. Only if a source property with the same name exists the...

Sorry, I missed PR #198. That indeed looks like the correct fix for #194. I'll go ahead and close this one in favor of PR #198

Hey @unshare, Just wanted to share with you PR https://github.com/mapstruct/mapstruct-idea/pull/202. We upgraded the baseline to Java 17. Giving you the heads up as your PR also is doing that 😄.

Thanks a lot for looking into this. > You can add a `META-INF/services/ch.qos.logback.classic.spi.Configurator` file that references a `Configurator` implementation which has the following signature `ExecutionStatus configure(LoggerContext context)`. That looks quite...

I had more time to try it out today and my custom configurator gets registered properly and I can add a custom converter. However, the Spring Boot [`LogbackLoggingSystem`](https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/LogbackLoggingSystem.java) resets everything...

MapStruct has the concept of adders and that is why it doesn't complain for `addChild` it treats it as an adder. Whereas for `removeChild` it treats it as a property...

I am not a big JPA user so I can't say much about best-practices there. As far as I remember this is one of the first issues that has asked...

Nice work @Hypnagokali and @zyberzebra. Good catch with the `null` and empty `SelectionParameters`. I pushed one small polish commit. I'll merge this once the build is done

And you are right @zyberzebra #3532 does look identical to this one. I'll close it out

@tokazio, I believe that you are need, should be properly resolved with #3216