Filip Hrisafov

Results 385 comments of Filip Hrisafov

Wouldn't it be better to use the GitHub [tool-cache](https://github.com/actions/toolkit/tree/master/packages/tool-cache) for this?

I think that it does not work with Webex Teams. Should we open a new issue for this or is this one sufficient?

Thanks for letting us know @bdkjones. I will try to get in touch with the Webex Teams support through our company support.

`XmlGregorationCalendar` uses `DatatypeConstants#FIELD_UNDEFINED` for fields that are not set. I don't know what would be best to do, but one possibility would be to check that the fields which are...

@lukas-krecan those methods were made final in order to make a better experience for the invokes of those APIs. There are no warnings now. You don't have to copy anything,...

I'd like to chime in regarding this. I have some experience via MapStruct regarding bean properties / fields. We rely mostly on the [Java Beans Specification](https://download.oracle.com/otndocs/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/) when determining what is...

I was talking about the `GetterIntrospectionStrategy` as I saw things in there that I think might not work in some cases. The idea for the possible API is valid for...

Forgot to add something #2111 was originally about `hasFieldOrProperty` where I guess it is fine to throw an exception when the map does not contain the key. However, when extracting...

>We've already realized that this method is involved in too many flows and we're doing too much here, so we're planning some refactoring to make sure each assertion is flexible...

In my opinion `extracting` should just do `Map#get` and not try to check if the map contains the key, i.e. the same as it was in 3.19.0. I am not...