Filip Bech-Larsen

Results 14 comments of Filip Bech-Larsen

I was hoping you had an opinion about that :-D Something like withProperties would be the obvious choice but we shouldn't really stick more on that - I don't think...

My thoughts on what tests to start out with... The different allowed property-types - should keep their types when changed from prop or via attr - attr sets prop (if...

Im not sure that eliminates the need completely... it does cover the most important part though... What if a property change causes something async to happen (a fetch or similar)...

yeah, I built a simple element-router that is meant for webcomponents - I was thinking about lit-element when I made it, but didn't make a depend on it... https://github.com/filipbech/element-router But...

could be related to shadow dom?

yeah, I saw you did the same thing on invalidate... or maybe the connectedCallback could actually return a promise that resolves? this seems kind of "hacky" and async/await compiles down...

super.connectedCallback currently returns undefined... do you have something locally or on another branch? https://github.com/kenchris/lit-element/blob/master/src/lit-element.ts#L87 - no return

that is a valid point... what would you suggest? lifecycle hook or something completely different?

Sorry for the delay (missed the notification apparently) No, thats right. I missed that in the readme. Maybe you could distribute both versions? Or at least my opinion would be...

Yeah, thats what I was thinking... for now its only a note-to-self on an idea! My main focus is keeping it lean and simple... but if you can think up...