Fredrik Hyyrynen comments

Results 5 comments of


                                            Fredrik Hyyrynen

fix: added parameter to optionally rename aliases of aggregated columns used in GROUP BY statments

Thanks for the quick feedback! @villebro I tried the `_mutate_label` function and it also solves the issue, but I'm not sure if I agree that this is the solution to...

fix: added parameter to optionally rename aliases of aggregated columns used in GROUP BY statments

Yes. The fact that Drill supports aliases in `GROUP BY` makes this example query ambiguous: ``` SELECT length(n_name) AS n_name FROM (select * from cp.`tpch/nation.parquet`) GROUP BY length(n_name) LIMIT 10;...

fix: added parameter to optionally rename aliases of aggregated columns used in GROUP BY statments

Closing this for now. I'm working on fixing the issues with the tests and also updating my fork to the latest version. I managed to break this PR in the...

fix: added parameter to optionally rename aliases of aggregated columns used in GROUP BY statments

I created a new pull request with a slightly different implementation and based of the newer version: #29455

Drill uses aliases in group by statements generated by SQLA resulting in no data when aggregating columns

I have implemented a fix based on the suggestion. This can be found in PR #29455 . I'm currently maintaining an image with this fix for my company, keeping it...