Fried Hoeben

Results 118 comments of Fried Hoeben

Is there an explicit reason multiple selenium jars are explicitly listed as dependencies? If there would be only one dependency (on selenium-java, which depends on all of the other explicitly...

Looks pretty good. Can you add some proper whitespace before the `{`s? And maybe it would be good to also offer a url decode?

Doesn't just maximising the browser's window suffice to control position? On the topic of downloading files: see my remark in #300

I don't mind adding a method to postion the window, although I would put most of the logic in a new method in SeleniumHelper. Can you make a PR for...

Which version on the fixtures are you using (since we never supported selenium 4.0.0)? Can you describe the setup 'parallel firefox browser testing'? Which processes/machines are involved (I don't suppose...

if you are looking to get similar behaviour as `clickInRowNumber()` I suggest you solve the problem similar to `clickInRow()`: ``` protected boolean doubleClickInRow(By rowBy, String place) { return Boolean.TRUE.equals(doInContainer(() ->...

The `GridBy` class does allow you to get a cell in a row based on its column header: `columnInRow(String requestedColumnName, int rowIndex)`, but that gets the cell not an element...

@violinner indeed you get a file-save-popup if you have selenium click on a file download button or link and you can't manipulate such a popup with selenium. That's why BrowserTest...

I believe a standalone fixture to deal with OS windows seems like an excellent idea. But can you elaborate on why you cannot just use the 'download ...' methods in...

@violinner what are your experiences with BrowserTest's 'download...' methods? Can you elaborate why they do not allow you to download the files you need?