Felix H. Dahlke

Results 16 comments of Felix H. Dahlke

I hadn't anticipated that problem to be honest, good point. I have nothing against it, really. It was more of an old habit of mine to use LGPL for libraries....

So, according to my lawyer, it's fine. It doesn't have to be technically linked, it's more the spirit of the license that matters in case someone claims a violation. So...

True, didn't think of that :smile: I'll contact the contributors and look into switching to EPL then.

@simonl2002, @annapawlicka, @jimmythompson and @trevor: I couldn't find your email address on GitHub, so I'll try it this way :smile: Could you comment here on whether you give your consent...

I'm not so sure, to me this looks like you want it to loop over the string hello. But both the Ruby and JS implementations print it just once, so...

Yeah, that's quite definitely a bug. Seems like it slipped through the spec tests.

Agreed, that sounds useful.

Sorry, slipped off my radar :disappointed: Reviewed the pull request, pretty much ready to merge.

I don't fully understand this, partials are [already](https://github.com/fhd/clostache#partials) passed as strings. Could you give an example of what you mean?

Yeah, that'd make sense.