Federico G. Schwindt

Results 140 comments of Federico G. Schwindt

@tr4nt0r I've opened https://github.com/zigpy/zha/pull/300 to handle the calibration min/max values update.

@TheJulianJES any chance you or someone from zha can review and merge this? 🙏

> I exposed the valve closing and opening but when trying to change the value I get: Failed to perform the action number/set_value. Failed to write attribute valve_closing_degree=33: Is there...

@nbrezovec > Hello team. I'm new to this. Is there any way to add the missing AUTO mode? In the picture you can see how it looks via Sonoff LAN...

Nice! I was testing a similar change using the Quirks Builder v2 and exposing the state as a sensor. I'll probably open a PR on Monday, as I wrote most...

> Hi @fgsch > > Thanks for your review comments, much appreciated! Given you've gone to the work of writing yours, I would definetly push it up. I wasn't aware...

And finally, here's my PR: https://github.com/zigpy/zha-device-handlers/pull/3346 I managed to get the sensor working as I wanted with help from some devs in discord. Unfortunately, it is not yet possible to...

I left some comments, but it looks good. I won't be able to test it until this weekend, though.

I've tested this quickly, and it works as expected. If you could address https://github.com/zigpy/zha-device-handlers/pull/3340#discussion_r1802032875 I think I'd be ready to go from my POV.