Federico G. Schwindt
Federico G. Schwindt
LGTM. Thank you!
@Gatsby-2024 I'm afraid I don't have permissions to merge, so we'll need to wait for @TheJulianJES or someone else to do so.
@Gatsby-2024 please don't add more changes, and in particular other files. Those should go in a separate PR.
@netdiver Hi. Thanks for the report. I haven't seen this before but I just checked my logs and I'm seeing the same issue. I will have a look and update...
Ok, I see what the problem is. I will push an update tomorrow.
@netdiver the issue should be fixed now. Thank you again for the report.
Regarding exposing this, I can add it to this PR in a disabled state but I wonder how often would people require to change this and whether it's something that...
> [..] > From my point of view the valve % are the best change to make this device really control temperature instead of either turning fully on or off....
Updated with code from @GregersP to expose the opening and closing degrees but disabled by default.
@tr4nt0r thanks, I will update the PR and check if there are other updates worth bringing in from zigbee-herdsman-converters.