Felipe Garay
Felipe Garay
Hi @maliberty , this is a big PR but it is mostly code generated by the code generator script. Thanks!
> I see many resolved comments but not the usual clang-tidy thumbs-up. Is there something not yet resolved? Yeah, most of them are in code that I am keeping the...
Hi @maliberty, I think this is ready for another look, thanks!
> #4617 and this PR are about to contend on the db schema. Would you be ok if that one goes first and you take the merge? Sure, no problem!...
Hi @maliberty , rebased the change. Had to force push the bump of the schema version but should be good to go. Thanks!
>ready for review or still working? Yep, ready for review :). The git history is a mess in this PR so let me know before merging so I can clean...
hi @maliberty, >It would be good to have descriptive comments for the new classes in db.h Is there any way to add comments to the auto-generated classes? Thanks! Edit: To...
No, it disappears. I see other comments for some classes there (ex: dbTechSameNetRule), but I am not sure how they are preserving those comments. Meanwhile I am adding comment for...
Hi @maliberty , That makes sense! Do you want me to include that in this PR or would you send one with your code? Thanks!
Hi @maliberty , when you have the time could you please re-try the unit test? I tried to see if I can reproduce it in my local machine but wasn't...