Fei Gao

Results 10 comments of Fei Gao

> I can run this through our testing but please resolve the merge conflict first. Thanks @TobiHartmann. I'll fix the conflict ASAP.

> Thanks, I can see failures with the following tests when running with `-XX:+UseCMoveUnconditionally -XX:+UseVectorCmov`: > > * `compiler/c2/TestCondAddDeadBranch.java` > * `compiler/loopopts/TestCastFFAtPhi.java` > > They also happen without this patch....

> Okay, please go ahead and file a follow-up bug then. Sure. I filed a new JBS issue in https://bugs.openjdk.org/browse/JDK-8293833.

> Changes looks good. Please, add testing for swapped inputs (when you negate condition). Thanks for your comment @vnkozlov . Updated it with some new tests.

Thanks for your test work @vnkozlov . Also thanks all for your review and comments. I'll integrate it. /integrate

> May I ask if we can vectorise `Bool -> Cmp` into `VectorMaskCmp` and `CMove` into `VectorBlend`, this would help vectorise the pattern you mention in the description instead of...

@chhagedorn thanks for your review and comments! I updated the commit to resolve the code style issue.

> Thanks for the update, looks good and testing passed! @chhagedorn thanks for your review and test work!

> Does `compiler/c2/irTests/TestVectorConditionalMove.java` IR test cover this case? Can you add it if it is not already? Thanks for pointing it out @vnkozlov . Updated the IR testcase in the...

Thanks all for your review and comments. I'll integrate it. /integrate