Francesco Romani

/priority backlog /triage accepted

LGTM (non-binding)

/remove-lifecycle stale

> This is a nice idea, but it seems to reinvent locally concepts partially emerging from contextual and structured logging (https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md) > > I'd change direction a bit in the...

/triage accepted /priority critical-urgent I think this will be backported to 1.31, right?

> /lgtm > > Should we add a test to make sure we don't accidently regress this in the future? yes. We do have already device manager tests though, and...

> It looks like these are the tests https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/device_manager_test.go? Yes. And also https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/device_plugin_failures_pod_status_test.go and https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/device_plugin_test.go at least. > Unfortunately, we don't currently have ability to [run e2e_node tests on Windows](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/e2e-node-tests.md#node-end-to-end-e2e-tests)....

/lgtm the revert looks good. Bummer that we can't run the device manager tests on windows, but it seems we got some coverate thanks to @jsturtevant

> @jsturtevant This pull request can be reverted, as of pull request #127076 kubernetes uses go 1.23, so the previous code is functional again. Thanks for the update! the process...

/cc @SergeyKanzhelev @bobbypage I believe this is indeed a bug and the issue makes sense to me. WDYT?