Fix: Fail admission check upon empty overhead map

[nmreadelf]

What type of PR is this?

/kind bug

What this PR does / why we need it:

the runtime class admission has a validation check against pod's .spec.overhead field. This validation is not correctly implemented because it's still failing requests if the request payload just has an empty map e.g.:

apiVersion: v1
kind: Pod
metadata:
  name: nginx
spec:
  containers:
  - name: nginx
    image: nginx:1.14.2
    ports:
    - containerPort: 80
  overhead: {}

Which issue(s) this PR fixes:

Fixes #https://github.com/kubernetes-client/java/issues/3076

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: nmreadelf / name: nmreadelf (8b0b3ca035b3aaf204fbddb755850ce0ec20ad5e, 51e09fbc55b49953846124ec1ad8548b0837b330, 20f00018e023952f1ed918c08eb990fe43718ad6, 929e1fc893e4ae63edde41954c1353c7b1447119)

[k8s-ci-robot]

Welcome @nmreadelf!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @nmreadelf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dims]

/sig node

[nmreadelf]

Hello. Could you please assist in merging this pull request? It has been open for over a month. @dims @ffromani

[dims]

/assign @mrunalp @SergeyKanzhelev

[ffromani]

/priority backlog /triage accepted

[ffromani]

LGTM (non-binding)

[nmreadelf]

Hello @deads2k and @jpbetz , could you please help approve this PR? It's been nearly two months since the last comment.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ffromani]

/remove-lifecycle stale

[bart0sh]

/assign @mrunalp @SergeyKanzhelev for approval

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[nmreadelf]

/remove-lifecycle stale

[SergeyKanzhelev]

/assign @tallclair

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nmreadelf, SergeyKanzhelev Once this PR has been reviewed and has the lgtm label, please ask for approval from tallclair. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• plugin/pkg/admission/runtimeclass/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[nmreadelf]

/retest