Frank Filz comments

Results 698 comments of


                                            Frank Filz

fix the use of unsafe functions strcpy to strlcpy

I like the original code. The convention I've been following for the nfs-ganesha code is if length has been checked so it's impossible to overflow, then strcpy is fine. If...

fix the use of unsafe functions strcpy to strlcpy

I think we can close this one.

4.3: build fails

Looks like this was fixed in pull request #279

Use GNUInstallDirs

I'm going to close this, I don't see us working on this any time soon or anyone contributing a patch.

Is this log indicating a bug?

bump...

memory leak using udp

There is a pull request: #271

Add RETRY in svc_destroy_it to prevent destroying uninitialized xprt

I think we need to do something different to synchronize shutfown.

Add RETRY in svc_destroy_it to prevent destroying uninitialized xprt

That looks good to me now, but I would like @dang to review also.

Send queues

This must be invalid... 243 commits? Closing

svc_destroy_it will destroy an xprt without xp_ops initialized

See also Ganesha issues: https://github.com/nfs-ganesha/nfs-ganesha/issues/1073 https://github.com/nfs-ganesha/nfs-ganesha/issues/1086 I think there needs to be more synchronization for svc_shutdown.