ntirpc icon indicating copy to clipboard operation
ntirpc copied to clipboard

Add RETRY in svc_destroy_it to prevent destroying uninitialized xprt

Open xueqianhu47 opened this issue 1 year ago • 2 comments

During showdown, ganesha tries to desstroy all xprts, but then crashes because ganesha assert a xprt to be destroyed must have xp_ops initialized already. But in svc_vc_ncreatef and svc_fd_ncreatef, we don't have lock to protect the allocation and initialization part to be together. Shutdown could happen in between, in this case, above assertion will fail Instead of directly asserting, RETRY with some sleep to wait for the initialization of xp_ops to be done

xueqianhu47 avatar Feb 21 '24 05:02 xueqianhu47

Please help review

xueqianhu47 avatar Feb 21 '24 05:02 xueqianhu47

I think we need to do something different to synchronize shutfown.

ffilz avatar Feb 21 '24 19:02 ffilz

That looks good to me now, but I would like @dang to review also.

ffilz avatar Aug 05 '24 19:08 ffilz