ffacs comments

Results 15 comments of


                                            ffacs

[C++] uniform identifiers naming style.

The following `.clang-tidy` file can help us to check naming styles mismatch. And we can use `clang-tidy` to fix them. ``` Checks: "-*, readability-identifier-naming, " CheckOptions: [ { key: readability-identifier-naming.PrivateMemberSuffix,...

[C++] uniform identifiers naming style.

> Could we add `NOLINT` to those public/protected variables? Sorry for my confusing expression. What I mean just like below https://github.com/apache/orc/blob/e1f185eedd7dc0d9d60339117c9299f5b26ddeaf/c%2B%2B/src/ConvertColumnReader.cc#L26-L33 The `readType` is a protected member of `ConvertColumnReader`. if...

ORC-1711: [C++] Introduce a memory block size parameter for writer option

> > @luffy-zh Thank you for making the PR. Could you explain why we need `outputStream->getRawInputBufferSize()` to record position? it seems that `flushedSize` and `bufferPosition` were't changed. > > When...

ORC-1711: [C++] Introduce a memory block size parameter for writer option

@luffy-zh Thank you.

C++ API. When the row I seek to is in the same row-group as the current row, why don't use the skip function directly, but instead seek to the row-group again and then skip?

An error will occur if a user attempts to read line 129 after reading line 130 without performing SeekToRowGroup again.

ffacs

[C++] uniform identifiers naming style.

[C++] uniform identifiers naming style.

ORC-1711: [C++] Introduce a memory block size parameter for writer option

ORC-1711: [C++] Introduce a memory block size parameter for writer option

C++ API. When the row I seek to is in the same row-group as the current row, why don't use the skip function directly, but instead seek to the row-group again and then skip?

ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp

ORC-262: [C++] Support async io prefetch for orc c++ lib

[Java] Different semantic of lengths for CHAR(n) with C++

ORC-1920: [C++] Support `Geometry` and `Geography` types

ORC-1920: [C++] Support `Geometry` and `Geography` types