orc icon indicating copy to clipboard operation
orc copied to clipboard

ORC-1920: [C++] Support `Geometry` and `Geography` types

Open ffacs opened this issue 6 months ago • 3 comments

What changes were proposed in this pull request? Support Geometry and Geography types for c++ side

Why are the changes needed? Add support for Geometry and Geography types

How was this patch tested? UT passed

Was this patch authored or co-authored using generative AI tooling? No

ffacs avatar Jun 16 '25 10:06 ffacs

Gentle ping, @ffacs .

dongjoon-hyun avatar Jun 23 '25 18:06 dongjoon-hyun

Gentle ping, @ffacs .

Pong. Thank you for your review @dongjoon-hyun , I'd update this patch these days.

ffacs avatar Jun 24 '25 03:06 ffacs

Thank you, @ffacs . Also, please participate the 1.8.10 vote too when you have some time.

dongjoon-hyun avatar Jun 24 '25 14:06 dongjoon-hyun

Could you fix the above comments, @ffacs ?

dongjoon-hyun avatar Jun 30 '25 15:06 dongjoon-hyun

Let me know when ready to review.

wgtmac avatar Jul 03 '25 04:07 wgtmac

@wgtmac @dongjoon-hyun I'm ready to review now, please take a look when you're free~

ffacs avatar Jul 03 '25 06:07 ffacs

Thank you, @ffacs .

dongjoon-hyun avatar Jul 04 '25 00:07 dongjoon-hyun

Is this ready or do we need more revision, @ffacs and @wgtmac ?

dongjoon-hyun avatar Jul 11 '25 21:07 dongjoon-hyun

Is this ready or do we need more revision, @ffacs and @wgtmac ?

My only concern is the name of public api: https://github.com/apache/orc/pull/2269/files#r2184135226. It is better to use getCrs() and getAlgorithm()/getEdgeAlgorithm()

wgtmac avatar Jul 13 '25 02:07 wgtmac

Thank you everyone, @ffacs , @williamhyun , @wgtmac . Merged to main/2.2.

dongjoon-hyun avatar Jul 14 '25 00:07 dongjoon-hyun