Feross Aboukhadijeh

Results 609 comments of Feross Aboukhadijeh

Support may need to be added to [`airplay-js`](https://github.com/guerrerocarlos/node-airplay-js). I'm not sure if subtitles are already supported or not. And we'll need to add support in webtorrent, but that part should...

This issue should be filed in `webtorrent-cli` now that that is a separate package. If someone's looking to fix this, I suggest switching the cli to use https://www.npmjs.com/package/airplayer by @watson...

No -- it's unrelated. I just think it'd be better to have the CLI using the same package as the Desktop app.

There's an eslint config for it. https://github.com/feross/eslint-config-standard/blob/master/eslintrc.json

@zz85 Some of our rules come from plugins. Those error look related to missing the `eslint-plugin-standard` and `eslint-plugin-promise` plugins.

This seems reasonable. It will definitely simplify things in `webtorrent-desktop`. A few suggestions: - There should be a `state.torrents[i].infoHash`. Torrent info hash if known, otherwise `null`. - I would change...

Yes, selections are how ranges of bytes in the torrent are prioritized behind-the-scenes. It's basically an array of objects that specify `start` and `end` bytes. You can see the default...

@dcposch Do you have thoughts on the design of this?

Fair point, once WebTorrent Desktop exposes this functionality in Preferences, we'll probably need this functionality.

> @kireerik Currently I am not actively using WebTorrent Desktop because it produced irrelevantly high download statistics on the torrent site that I am using. Maybe because it usually checks...