Feross Aboukhadijeh comments

Results 609 comments of


                                            Feross Aboukhadijeh

Github sponsors support

This is a cool idea. PR welcome!

Integration with Webamp?

@captbaritone Hi there! Just catching up on GitHub issues (sorry for the delay!). I'm down to modify the API to suit your needs. Would you just need a way to...

[wip] return a promise when there is no callback in concat

Thanks for the PR! I was planning to look into Promise support for the next major version. A couple thoughts: 1. What do you think about dropping the callback interface...

[wip] return a promise when there is no callback in concat

@mcollina I want to think about this a bit more before deciding what to do.

Remove require('url') in favor of URL

It's possible to do `new URL('...', 'http://example.com')` to parse a relative URL.

Analyze file type rather than guess from filename

I think this is a promising strategy. Do you have an idea for how to accomplish this? I'd be happy to look at a PR if you want to send...

remove require('url') in favor of URL

Could you explain a bit more about the changes, like why you were able to remove the different code paths for relative/absolute URLs, and why you're now passing `href` in...

Support text/uri-list MIME type for onDropText

What browser are you using? I just tested the version on `master` and it seems to handle dropped anchor links just fine without the changes in this PR.

Support text/uri-list MIME type for onDropText

@Twixes Can you confirm that this issue still exists on the latest version of electron, which I believe we're using on `webtorrent-desktop` on the `master` branch? Let me know if...

Drop minified code for browsers in favor of CDNs

I think this is okay. But note this is a major version / breaking change.