Piotr Korowacki
Piotr Korowacki
Can You provide an example of a file before encode and after decode? If i understood correctly (from the "fix" code) to have your image written correctly You must put...
I looked at the IntelHex standard again, and I realized that Starting Address record types are numbered higher then Data and Extended Adress records. So maybe this implementation isn't that...
Yes, that is the Start Linear Address record all right. As I already wrote. Current implementation always places Starting Address records at beginning. So no matter where it will be...
Why You have in Your Hex file Start Record on the end? Probably by a software design. @bialix already wrote that there isn't only one place to put that record....
the problem is not with merge function, but with __getitem__ method (alows to use indexer "[ ]") probably noone used it, therefore never tested properly current implementation doesn't support slicing,...
Hmm, I didn't see that before, but there is a pull-up request (old one though), which is strongly related with this topic: #5 That makes a little different approach. It's...
I see no problem in "merging" both solutions. The only thing here is what You consider as common part and what is need to be changed. This can be done...
Hi, thanks for feedback :) I have a question. Have You check the code in this pull-up request? Most of that You wrote is done (core part). Only few details...
I've added a new option for 'ext_addr_mode' - 'none'. When selected it only checks if last address fits into 64KB. It's just to have consistent solution for all options ('segment',...
> I can't see unit tests for new feature. Can you add some? Test for new 'none' option are there. I didn't do special test suite for it. Just added/changed...