Fernando Hoyos

Results 31 comments of Fernando Hoyos

This test flake has arisen again: https://github.com/kiali/kiali/actions/runs/8983429993/job/24674669551

Thanks for the updated PR @BlueBiuBiu! There is an issue with unit tests. It seems that latest i18next version only works with Typescript 5 and Kiali uses Typescript 4. From...

> Ok, I have downgraded the version to before updating typescript 5 Please commit the `yarn.lock` file together with `package.json`

Some unit tests are not working because $t is not being recognized (global window variable is not defined in unit tests). You can try mocking $t variable in the specific...

Hi @BlueBiuBiu, have you had time to check the test issue? I have tried from myself and I have not been able to make unit tests to recognize $t windows...

Hi @BlueBiuBiu, no problem, glad you hear you again :-). If you have seen my [comment](https://github.com/kiali/kiali/pull/7014#issuecomment-1906116134) above I spent some time trying to make global variable $t work with unit...

@BlueBiuBiu, I think we are on the same page :-). I am going to work these days on my PoC to convert it to real PR that can create i18n...

@BlueBiuBiu I have i18n support PR ready here https://github.com/kiali/kiali/pull/6843. Please take a look and let me know your thoughts, any feedback is welcome :-)

OSSM 2.5 is released, so we can merge backports to v1.73 branch

Do not merge until OSSM 2.5.0 is released.