ferencdg

I think there are 2 smaller problems with this contract: 1. it seems you allow 38 different numbers, but a roulette only has 37 numbers: https://github.com/k26dr/ethereum-games/blob/3128272012f7dc6678332533aa97bad29411ba62/contracts/Gambling.sol#L114 2. you don't have...

I think there is problem with that RNGLottery contract. If I am an attacker, I can have 3 addresses and buy 3 different lottery tickets. During the reveal phase I...

Powerball drain all account balance

1

This issue only happens if there are periods when the powerball contract is not actively used, and if any period like that exists, then I could draw all the account...

when using @headerParam("paramName", "fieldName") the value of paramName parameter is *ALWAYS* serialized by calling 'to!string', but deserialized by calling 'fromRestString' which in turn might use json deserializer. Sending the following...

If contract A needs to have a reference to contract B to work correctly, then deploying contract A should be preceeded automatically by deploying contract B. In config.terrain.json there should...

if I exectute terrain task:run, then the environment variables are not inhereted in the actual task, this is a problem if I define the keys in keys.terrain.js as environment variables

current BaseHook implementation makes hooks hard to combine

2

### Component Pool Interaction, Hooks ### Describe the suggested feature and problem it solves. I have two hooks: HookA, HookB and both of them derives from BaseHook and also initialize...

[Bug]: access modifier should be internal for _rebalance in the FullRange example (security related)

2

### Describe the bug https://github.com/Uniswap/v4-periphery/blob/581d96dfd8b281cafe351205bf6d2d65efb4df90/contracts/hooks/examples/FullRange.sol#L317 is public ### Expected Behavior should be internal ### To Reproduce _No response_ ### Additional context _No response_

### Describe the bug beforeInitialize should check if it is called by the PoolManager and revert if it isn't In the current version anyone can override the liquidityToken in the...

### Component General design optimization (improving efficiency, cleanliness, or developer experience) ### Describe the suggested feature and problem it solves. You could use the deployCodeTo function in Hook tests from...