FiWend comments

Results 3 comments of


                                            FiWend

ctr task attach stdin/stdout competition with cri-container

`ctr` created a new `stream` and `fifo` to do the `io.CopyBuffer` of stdin/stdout/stderr https://github.com/containerd/containerd/blob/59c8cf6ea5f4175ad512914dd5ce554942bf144f/pkg/cio/io.go#L162-L182 However, the `cri` side is a copy made by the `containerdIO` https://github.com/containerd/containerd/blob/59c8cf6ea5f4175ad512914dd5ce554942bf144f/internal/cri/io/container_io.go#L178

ctr images list API, avoid multiple prints of duplicate images.

https://github.com/containerd/containerd/blob/566f9f48db6f6bc7dbd76d70aa425afbee7b0d0a/internal/cri/server/images/image_pull.go#L238-L241 @Random-Liu @mxpv @fuweid I've always wondered why an image needs to write imageID, repoTag, and repoDigest to the meta.db? I understand the necessity of each individually, but why are...

Add a timeout retry mechanism and Returns an error directly when StateCtx deadline exceeded

> Hi @fengwei0328 I see that the retries were removed from this PR, was there a problem with them? From my understanding, we need the retries in order to fix...