Mariusz Felisiak

Results 214 comments of Mariusz Felisiak

> Both DefaultStorage and ConfiguredStorage use this method so we'll get a deprecation warning from there. Should I deprecate these classes separately with custom deprecation messages? Yes we should deprecate...

@Scalamoosh Thanks for this patch :+1: IMO, we still have a big unanswered question about submitting _chosen_ vs. _selected and chosen_ values. We didn't reach a consensus on the ticket...

> For reference, the latest changes are causing two type of failures on Oracle > > 1. `expressions_case.tests.CaseExpressionTests.test_annotate_with_full_when` failure is unrelated; it's a regression introduced by [Fixed #33895 -- Fixed...

@charettes Thanks :+1: I moved the first commit with two extra small cleanups to the #15945.

Merged the first two commits in 35911078fa40eb35859832987fedada76963c01e and 8c3046daade8d9b019928f96e53629b03060fe73.

@ab-revanthgss Do you have time to keep working on this?

> I tried looking into changing queryset argument to querysets. I think one good solution is to have a GenericPrefetch class that subclasses from Prefetch class to support querysets. To...

> @felixxm not sure if it's known but Jenkins Oracle nodes seem to be broken > > ![](https://camo.githubusercontent.com/0ffcceae9be70bb671e8390ead6e7fb917d4ccc359f04c15c501b54615613c67/68747470733a2f2f63646e2e7a617070792e6170702f61353461303766633839663733356662383939663965636335653262396263372e706e67) Sorry my bad, should work now.