Felix Handte comments

Results 60 comments of


                                            Felix Handte

Issues in zstd man pages

I believe I've addressed all of these in the linked PR.

Fix build failure in Alpha architecture

@henrich, @arnout, we're ramping up to our next release and I'd like to get a fix for this issue merged. I can make the test as follows: ```c #if ((PLATFORM_POSIX_VERSION...

Fix build failure in Alpha architecture

In the absence of any activity, I'm going to close this. If anyone with an alpha system can comment on the appropriateness of the proposed fix, I'm happy to re-open...

LLVM mingw bug AddressSanitizer: use-after-poison on address

@calvin2021y, can you share a little more about this issue? I don't see `-fsanitize=address` in the list of arguments you're providing to the build.

Update Copyright Comments

@Cyan4973, that seems to be [the guidance](https://www.internalfb.com/intern/wiki/Open_Source/Licenses/).

compressed file ownership inconsistent with that of uncompressed file

@Kawashima-Azumi, I am about to put up a PR that addresses this issue, and switches `zstd`'s behavior back to copying the source file's attributes to the output file. Your review...

For help: I want to replace zlib with zstd in my project (like zsync) , it works now, but compress speed is quite slow.

1. If speed is important to you, you should avoid using very high compression levels. 2. To be clear, zlib is also O(dictSize), they're just limited to very small dictionaries....

For help: I want to replace zlib with zstd in my project (like zsync) , it works now, but compress speed is quite slow.

@Cyan4973, yeah this is a topic that's come up at least once before that I can recall. This is of course an abuse of the zstd frame format... but it...

For help: I want to replace zlib with zstd in my project (like zsync) , it works now, but compress speed is quite slow.

You could also implement it by inspecting the first few sequences after the matchfinding has run.

Please produce binaries for the latest versions

In general we rely on distros to produce the binaries for their OSes. But yes it's disappointing that the LTS releases don't update the zstd package. Technically, versions before 1.4.9...