zstd icon indicating copy to clipboard operation
zstd copied to clipboard

Please produce binaries for the latest versions

Open mikhailkoliada opened this issue 3 years ago • 6 comments

Hello!

I am a member of the team responsible for GitHub Actions hosted runners and Microsoft-provided agents in Azure DevOps. zstd is a highly-demanded package amongst GitHub customers, apart from that, the actions/cache action hardly relies on the zstd installed in the images we provide.

As we only provide the LTS versions of ubuntu zstd is surely quite obsolete there, and as a result we have to install zstd using the linuxbrew package manager.

Due to recent changes in brew we had to remove it from our $PATH. Apart from that, we are considering mere reliable ways of shipping zstd to our customers (including possibility of providing a self-built binary), but before building it oursalves, we wanted to reach you and ask if it is possible to produce binaries for the latest versions, it might be probably a benefit for lots of people, not only GitHub.

Thanks!

mikhailkoliada avatar Oct 20 '22 11:10 mikhailkoliada

In general we rely on distros to produce the binaries for their OSes. But yes it's disappointing that the LTS releases don't update the zstd package. Technically, versions before 1.4.9 are affected by a CVE.

Have you considered grabbing the .deb from a newer Ubuntu release and installing it manually? I see that 22.10 packages the current version. Given that zstd (1) is nearly dependency-free and (2) has a stable API/ABI, I believe that should work.

felixhandte avatar Oct 20 '22 15:10 felixhandte

Hmm, we have not considered using deb from the newer ubuntu version, will check it out and let you know how it goes.

mikhailkoliada avatar Oct 21 '22 05:10 mikhailkoliada

@felixhandte 1.5.2 from 22.10 works on 22.04, but on 18 & 20 / 04 it depends on the toolchain libs still :(

image

mikhailkoliada avatar Oct 21 '22 12:10 mikhailkoliada

@felixhandte any thoughts? :)

mikhailkoliada avatar Oct 27 '22 17:10 mikhailkoliada

@felixhandte and now? :)

mikhailkoliada avatar Nov 22 '22 20:11 mikhailkoliada

Sorry for the radio silence.

Is there a reason you need us to build these binaries? Ultimately, what we would build would just be the result of git clone https://github.com/facebook/zstd && git checkout v1.5.2 && make zstd-release on that platform.

Edit: I see you call that out as an option in your original comment. Yeah, I think that's probably the easiest way forward here.

felixhandte avatar Nov 22 '22 21:11 felixhandte

In the absence of a reply, I'm going to close the issue. If you want to discuss further, please feel free to re-open.

felixhandte avatar Jan 12 '23 18:01 felixhandte

@felixhandte I ran into the same issue, hundreds of devices using zstd but they are stuck with an older version because of Ubuntu LTS.

This a valid issue, fixable via github actions.

gaby avatar Mar 08 '23 00:03 gaby

Seems like @mikhailkoliada found a fix. The github actions are using 1.5.4

gaby avatar Mar 08 '23 00:03 gaby