Felix Fontein

This part has multiple bugs: 1. It confuses empty data with `None` (which is a rather common problem); 2. It always checks whether the file named in `filename` exists, even...

> I'm not sure if this needs fixing and if so how It does need fixing. For the first one, check out https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins (which also gives you some more hints...

Right now it's not possible by using `---`. Most inventory plugins use comments to separate examples.

Did you try whether https://docs.docker.com/reference/cli/docker/login/#configure-the-credential-store works? The module already contains code for using credential helpers, though I don't know if it works. (I never used any of these.)

> This behaviour is different from a pure docker login call from the shell, where the credential store is preferred automatically without the initial need for modifying the configuration file....

(Also `docker login`'s behavior changed over time. It did store passwords in plaintext by default on Linux in the past. So using some magic that changes over time to select...

Thanks for reporting this! > Is this simply a case that the someone forgot to update the docs Yes...

Sorry, I completely forgot to reply... I've created a PR now (#1895) since I also found a few more places...

Kind of duplicate of #790. The collection does not support specifying both tags and digests so far. Adding support for this would be a new feature.

Also docker_swarm_service is not affected by our code, it does not use this function from community.docker, but the original code from Docker SDK for Python. Also the code in module_utils/_common.py...