Felix Fontein
Felix Fontein
Ah right, sorry, I missed that. @apollo13 does the PR look good now (assuming d2c35cf04c8aaf5f0175d772f862a796e22e35d4 is reverted)?
The ansible/third-party-check is constantly failing. Unfortunately it's not possible to remove it (I've tried and eventually gave up), so please simply ignore it :-(
Beside the above, I think this looks good (assuming that @apollo13 didn't change their mind). If nobody objects, I'll merge this on Sunday.
Good point. There are also some other properties missing.
#1134 implements the missing fields and types for docker_container.
I did quickly try this with various ansible-core versions (2.15, 2.16, 2.17, 2.18, 2.19, devel branch), and it worked fine for me. (Except some deprecation warnings with 2.19 and devel,...
Issues for the deprecations: - #10544 - #10545
Thanks, that indeed reproduces this! Interestingly, it works fine with ansible-core 2.19, it only fails with 2.18 (and likely before).
The problem seems to be how Ansible's Templar handles undefined variables. Basically before ansible-core 2.19, if a nested structure contains an undefined variable, it itself is seen as undefined. Since...
While the current version works, it is worse than the previous iteration since it now explicitly does not fix anything else than the case in #84116.