felix

Results 17 comments of felix

now i get (from travis) ``` The command "diff -u toxav.h ./toxav/toxav.h" exited with 1. ``` what is this supposed to mean? i don't think i have touched anything related...

i guess the commits (including e2df2ba) are are actually OK then. cheers

need to redesign my patch.. don't know how to do it yet. the value index datatype may be too small to represent twice the range. so actually the longer head...

On Wed, Jul 25, 2018 at 03:37:49AM -0700, Jeremy W. Murphy wrote: > I think the best thing is if you can make the simplest unit test that > fails...

On Wed, Jul 25, 2018 at 04:14:59AM -0700, Jeremy W. Murphy wrote: > I think it's best if you put the relevant unit test into this PR. > Whoever is...

thanks. I commited the test from treedec mentioned above. another bug in min_degree_ordering seems related to this. min_degree_ordering assert fails on some empty and on some complete graphs. see the...

On Fri, Aug 31, 2018 at 12:01:02PM -0700, jrmarsha wrote: > This may be tangled then. The PR needs to be clean and not affect > other parts of the...

On Fri, Aug 31, 2018 at 12:09:16PM -0700, jrmarsha wrote: > There really shouldn't be unintended side effects. I'm not going to > promote a PR that knowingly introduces regressions....

On Sat, Oct 13, 2018 at 08:49:58PM -0700, Jeremy W. Murphy wrote: > > [..] need redesign [..] > > Is this still an open implementation issue for this patch?...

On Sun, Oct 14, 2018 at 03:02:09AM -0700, Jeremy W. Murphy wrote: > Hmmm, maybe just something to do with the way I compiled it manually, > because when I...