Fredrik Eliasson

Results 8 comments of Fredrik Eliasson

I just wanted to add here that the current approach here for this `try`/`catch` block will not work, I know this because I have tested it. When not logged in...

Fixed slight adjustment to suggestion in #10236 to properly handle the error if not logged in, it would not enter the `catch` block otherwise

@mikhailkoliada @shamil-mubarakshin You guys made the latest commits to the `GenerateResourcesAndImage.ps1` helper script. What do I need to do to get some traction on this PR? I have waited 3...

@subir0071 - After nearly 6 months without any review or even a comment from any approvers, maintainers, or code owners, you're just closing this PR? This approach is incredibly ridiculous....

@subir0071 > * actual business logic is pushed to the [catch](https://github.com/feliasson/runner-images/blob/c160d48a28ff75dd7e102835fe04db75912cff1b/helpers/GenerateResourcesAndImage.ps1#L261) block. If you know of any other way to check if you're already logged in to the Azure CLI...

@subir0071 I’d also like to point out that if the changes in `GenerateResourcesAndImage.ps1` are a concern, the modifications in the Packer templates can be easily implemented without causing any breaking...

@jackofallops - Can we please move this forward? The PR author hasn't made any updates since January, and many people are waiting on this to be in place.

@jackofallops The PR author has added tests and requested another review. It would be greatly appreciated if this could be merged to resolve the issue.