Erick Fejta comments

Results 38 comments of


                                            Erick Fejta

[peribolos] Adding sub team to a parent team fails during dry-run

Are you offering to fix this edge case?

[peribolos] Adding sub team to a parent team fails during dry-run

I'm mostly inclined to just resolve this without fixing anything. You have declared a non-existent team for weeks. Why is this an important scenario? Just create the group (which peribolos...

[peribolos] Adding sub team to a parent team fails during dry-run

A dry run when you're declaring and using a team that doesn't exist isn't going to work though. You could break it up into multiple PRs: 1) a PR where...

[peribolos] Adding sub team to a parent team fails during dry-run

Alternatively you can disable the functionality that is not of interest: https://github.com/kubernetes/test-infra/blob/fb4c8c9bd8603ec9306bf3a59119274feb961f7f/prow/cmd/peribolos/main.go#L83-L102

workspace status command variable substitution for images

Is this still valid? We've replaced the python resolver with a golang one.

Dependency on volatile-status.txt breaks remote cache

General best practice here is to avoid stamping -- stamping is by definition volatile. Another practice we use over in kubernetes/test-infra is to separate out the stamp layer into its...

Handle kubectl diff exit code when diffs are found

/test all

Handle kubectl diff exit code when diffs are found

Please fix tests

Handle kubectl diff exit code when diffs are found

/retest

Handle kubectl diff exit code when diffs are found

/retest