Federico Paolinelli
Federico Paolinelli
Just nits, I like this a lot! One extra thought: if we are able to maintain a "allInterfacesForAllIPs" sort of map (maybe with a better name) we could even avoid...
Also, I'd like to get an extra :eyes: from @oribon, to see if I missed something
> Just nits, I like this a lot! One extra thought: if we are able to maintain a "allInterfacesForAllIPs" sort of map (maybe with a better name) we could even...
> > Couple of extra notes: I'd change the commit message (we are trying to adhere to https://cbea.ms/git-commit/ as guidelines) For later, when we converge on the review: I'd add...
> @fedepaol I have modified the func SetBalancer in announcer.go，review again? Sorry for the delay, I was off. Reviewed again!
> > > Couple of extra notes: I'd change the commit message (we are trying to adhere to https://cbea.ms/git-commit/ as guidelines) For later, when we converge on the review: I'd...
A couple of nits around the code, which is getting to look really good in my opinion, plus a comment about the e2e tests which I think needs to be...
Thanks for taking the time to iterate over this! The result is really neat. LGTM
@qingwusunny it'd be great if you can extend the e2e tests in a separate PR as we discussed in the past.
@cyclinder that'd be great! Assigning it to you