Federico Paolinelli

Results 511 comments of Federico Paolinelli

> @fedepaol I don't see how #1026 is related. MixedProtocolLBService is a Kubernetes feature gate and is about mixing TCP and UDP on the same LoadBalancer-typed service. Oh, sorry I...

Hi, sorry for the delay. This is supported by metallb. I also filed a PR to validate it in our CI. Closing the issue.

> Please provide a parameter, to pass address-pools along through Helm values and throw an error if `configInline` is set (to prevent destroying existing deployments). Yep, we were discussing with...

> hmm definitely getting spammed with alerts every time flux reconciles my git repo because of that validating webhook. Can you expand a bit? Are you getting the errors only...

> yeah it's after. i'll open a new issue regarding that. Thanks! It would help to have the logs of the controller raised as debug via the -loglevel flag

> First of all, thank you for your work in metallb, I am really happy to see progress here! 100 > > I have mixed feelings about this issue and...

I am gonna close this issue. @djryanj / @zrav / @fabricesemti80 would you mind filing new issues for your comments?

Overall looks good. I need to sleep a bit over the select loop and look at it carefully. Also, I'd be more comfortable in having at least one or two...

Couple of extra notes: I'd change the commit message (we are trying to adhere to https://cbea.ms/git-commit/ as guidelines) For later, when we converge on the review: I'd add also a...

Another round, mostly nits. It's converging :-)