Federico Ciardi comments

Results 198 comments of


                                            Federico Ciardi

ci: add old node versions to CI

We are still mentioning support for Node 8 both in the readme and in the package.json. I 100% agree we should remove it (maybe also Node 10), but we need...

feat: change `#toString()` behaviour for arrays

😁 I was still thinking about a few edge cases, but if they all pass I will just implement tests.

feat: change `#toString()` behaviour for arrays

Maybe wildcards and our custom validators for arrays.

custom sanitizer: Split String

@Inkbug Is there any particular use case for this?

query sanitation is not happening or not mutating req.query object

Does it work with `express@4` ? --- edit: I think it does (ref: https://github.com/expressjs/express/issues/2752). We should mention it in the docs as a FAQ.

query sanitation is not happening or not mutating req.query object

We can do nothing until express 5 is still a ~~beta~~ alpha :(

query sanitation is not happening or not mutating req.query object

Y, that does not mutate the original req object and works👍

Custom error param

I'm not sure of why you would like to change the param name that failed. `withMessage` accepts an object as a param, so the right place to perform this kind...

Re-usable validation, with optional() and exists()

This is something we should definitely implement because the same problem also happened to me. You may resolve with some kind of wrapper around `checkSchema`. (Keep also in mind that...

Re-usable validation, with optional() and exists()

- `exist()` and `isLength()` are quite different because the first one can check also non-string values and has a couple of useful options. - `optional()` applies to the entire chain....