Federico Ciardi comments

Results 198 comments of


                                            Federico Ciardi

buildCheckFunction default added only to req.body

This seems not to be caused by the `default()` sanitizer, but by `buildCheckFunction()` that evaluates field results as an union and not as an intersection. When the context is run...

Add "or" validation chain

Possible APIs: ```js ValidationChain#or(Custom Validator | (thisChain) => {}) ``` A custom validator which takes the result of the previous chain item and runs if that returned false. ```js ValidationChain#oneOf(itemA,...

Add integration tests

How about fixtures/snapshots where the output is the the `req` obj? It would give full control over what happened during the middleware execution.

Add integration tests

Thanks for the interest @danizavtz! I hope I am not too late, but here is a list of what integration tests should do in this case: 1. Accept an express...

fix(`checkSchema`): check all locations if `in` is not specified.

Hey @nikli2009 can you add a few more tests to check if #1010 is fixed by this?

normalizeEmail() API alters the email TLD (@yandex.com)

Hey there! You should try to update express validator to the latest version (`npm i express-validator@latest`), or open an issue at https://github.com/validatorjs/validator.js because we rely on that library.

Detailed docs

Fields are `required` by default and you can check for the existence of a value with `exists()`. For convenience we only document our custom validators, if you want to see...

Detailed docs

I will open an issue at `validator.js` to see if they can provide a more schematic approach to docs instead of just adding functions to the `README`.

An array in the querystring can (by)pass the validation if the first element is correct, but useless when expecting a single value.

Also related to #791

ci: add old node versions to CI

Oh, the version of jest we are using is not supporting node 8, I will fix it.