Florian Eckert
Florian Eckert
If you have a setup that doesn't work! Can you check whether the netifd calls the script? https://github.com/openwrt/packages/blob/master/net/ddns-scripts/files/etc/hotplug.d/iface/ddns Please add some debug log messages to see what happens
Formally, the code looks good. Personally, I don't like writing such commands into a uci config option. I think you have to consider a lot of things for escap sequennces...
* Please fix the CI/CD error. * Update your commit message why do we change this. * Prefix your commit headline with `ddns-scripts: `
Sorry you are still missing a correct `Signed-off-by: ` and valid commit message. In your commit -> https://github.com/openwrt/packages/pull/25148/commits/ea5cf1db09f6f43572e0b960cd994e81408b645b
@ownaginatious Now the commit is correct. You just have to bump the [PKG_RELEASE](https://github.com/openwrt/packages/blob/master/net/ddns-scripts/Makefile#L11) by one in this commit so I can merge this change.
Please bump the PKG_RELEASE. Change is OK :+1:
Sorry, I don't have time to investigate and verify this right now :-(
The mwan3 is written in `shell` and is therefore very fragile! Can we make the functionality configurable so that we don't break other setups?
Replaced by https://github.com/openwrt/packages/pull/25888