packages icon indicating copy to clipboard operation
packages copied to clipboard

ddns-scripts: fix porkbun updater to not delete subdomain on A/AAAA record

Open ownaginatious opened this issue 1 year ago • 1 comments

I noticed that the porkbun updater is changing my wildcard domain A and AAAA records from *.<domain>.<tld> to just <domain>.<tld> after the first run.

It would appear that Porkbun's API considers a missing name key to mean you want to drop the subdomain from the record (see here), which is probably not the intended behavior here.

This PR simply adds one line to correct that.

ownaginatious avatar Oct 15 '24 09:10 ownaginatious

  • Please fix the CI/CD error.
  • Update your commit message why do we change this.
  • Prefix your commit headline with ddns-scripts:

feckert avatar Oct 18 '24 12:10 feckert

@ownaginatious: Have you seen the @feckert comment?

Neustradamus avatar Oct 27 '24 14:10 Neustradamus

@feckert @Neustradamus thanks for the ping. I think I've resolved the issues.

ownaginatious avatar Oct 27 '24 22:10 ownaginatious

Sorry you are still missing a correct Signed-off-by: and valid commit message. In your commit -> https://github.com/openwrt/packages/pull/25148/commits/ea5cf1db09f6f43572e0b960cd994e81408b645b

feckert avatar Oct 28 '24 07:10 feckert

@feckert whoops, sorry about that. Does it look okay now?

ownaginatious avatar Oct 28 '24 16:10 ownaginatious

@ownaginatious Now the commit is correct. You just have to bump the PKG_RELEASE by one in this commit so I can merge this change.

feckert avatar Oct 29 '24 07:10 feckert

@feckert got it; fixed 👍

ownaginatious avatar Oct 29 '24 22:10 ownaginatious

Thanks, Merged!

feckert avatar Oct 30 '24 09:10 feckert