feathers-permissions icon indicating copy to clipboard operation
feathers-permissions copied to clipboard

Published 20 hours ago • verified publisher icon feathersjs-ecosystem

Dove Support

Open forgot opened this issue 3 years ago • 0 comments

Summary

  • [ ] Tell us about the problem your pull request is solving. Updated to work with ^5.0.0-pre.16
  • [ ] Are there any open issues that are related to this? No
  • [ ] Is this PR dependent on PRs in other repos? No

Other Information

This pull request updates the dependencies to ^5.0.0-pre.16. No changes were needed to the actual lib files. All tests now pass with npm test. If it would be better to do this as a full Typescript implementation, I can work on that.

Since the FeathersError properties data and errors are now optional and not used in the test, I removed them from expected result in the tests. I guess another option would be to use a Forbidden error with the expected message? I can make that change if needed.

It would obviously be better for this to remain it's own branch and did not merge with release or master, but there is not currently a Dove branch.

forgot avatar Feb 09 '22 07:02 forgot