Folkert de Vries

Results 16 comments of Folkert de Vries

I would love to see this as well, especially since `subscriptions-transport-ws` is deprecated and has been [largely unmaintained since **2018**](https://github.com/apollographql/subscriptions-transport-ws#subscriptions-transport-ws-is-no-longer-maintained). Unfortunately it's not just a matter of changing the protocol...

@stmarkevich @sergey-komissarov @prokher is there something preventing this pull request from being merged? I'm eagerly waiting for the initial payload feature to become available. :pray:

If this needs to be fixed, it's not just _filter_. Other icons match SVG or HTML elements as well: SVG elements: [circle](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/circle), [filter](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/filter) HTML elements: [code](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/code), [menu](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu), [option](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option), [table](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table), [video](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video).

For backwards compatibility this library could use a `Context` that defines default icon options (which defaults to size 24px). That way everyone can safely upgrade, but you could choose to...

@jiayinghsu I've since switched to [react-icons](https://github.com/react-icons/react-icons) which includes feather icons, defaults to `1em` and provides the aforementioned context for overriding the defaults.

Any update on this?

Thanks for the quick response @jaydenwindle. I have added tests and squashed a bug in the process. By the way, I'm getting warnings about the `id` variable overriding a built-in...

This issue was indeed fixed for me in `beta.48`, but seems to have returned in `beta.52`. @Banou26 can you check if the latest version produces the error for you again...

For some reason `npm install '@apollo/[email protected]'` kept installing version `3.0.0-james.33.0`, which is why it was broken again for me. This no longer happens with `3.0.0-beta.53`. Thanks for checking!

I'm replying to keep this issue from going stale. I would still like to see this implemented.