Fabian Dellwing
Fabian Dellwing
Still very much broken in the exact same way: ``` 95.90.204.x - - [29/Oct/2024:13:10:27 +0100] "GET /java_font_renderer/render?skin=skin-8&profil=font_menu-1-hovered&text=Ladybird%201 HTTP/1.1" 200 7093 "-" "Mozilla/5.0 (Linux; x86_64) Ladybird/1.0" 95.90.204.x - - [29/Oct/2024:13:10:27 +0100]...
You can also see the three requests with a `python3 -m http.server` (no logged referer though): ``` 127.0.0.1 - - [29/Oct/2024 13:28:48] "GET /classes.png HTTP/1.1" 200 - 127.0.0.1 - -...
But LB ist showing the favicon just fine. Also the size is not matching up. The "wrong" input had a size of ~13k and not ~16k like the favicon.
> In any case, this is very unlikely to be what causes the particles to fail to display. I agree. But it was all I could see at that point....
> > I still hope Jelle will just fix this and all the other issues with our company website because he asked :D > > Do you have specific issues...
There are 2 FIXMEs that seem like an easy fix but aren't. ```diff diff --git a/Libraries/LibWeb/HTML/TraversableNavigable.cpp b/Libraries/LibWeb/HTML/TraversableNavigable.cpp index 36870b5e98..073bc478fc 100644 --- a/Libraries/LibWeb/HTML/TraversableNavigable.cpp +++ b/Libraries/LibWeb/HTML/TraversableNavigable.cpp @@ -557,12 +557,13 @@ TraversableNavigable::HistoryStepResult TraversableNavigable::apply_the_history_...
If we comment out `entry->document_state()->set_ever_populated(true);` in https://github.com/LadybirdBrowser/ladybird/blob/fa262d2db5f2d3b75ca3a22b16634b4908055916/Libraries/LibWeb/HTML/Navigable.cpp#L1451-L1452 the browser stops crashing at startup, but that is clearly against the spec. So something else has to go on or be handled...
@gmta While it *kind of* works on the demo page (still looks nothing close to as it does in Firefox), it is still completely broken on the live website. (I...
Firefox (lots of lines with dots moving around and connecting to new dots) LB (a few feint lines, flickering all the time, no dots at all)
I'm running it on WSL2 + Ubuntu 22.04 + VcXsrv