Franck Cuny

As you said, having a constructor allows additional logic when creating the router. The way I see it, the router is not an ordinary object/type, but some kind of higher...

This is not final, I'm still improving and simplifying the code added to support this feature.

in fact, we don't want to change the value of the url, since it's also used to direct the user to the url of the repo. let's start by rewriting...

that's the one I was thinking about ... not ssh ... this url is not provided in the payload, so we need to build this url somewhere

commit b28268d cover part of this request. If one version has failed the tests, the name is in RED, else GREEN.

and also provide a feed with the same informations

there is another issue. If you are using perlbrew, and the build pass for every perl except one, should we color in red ? orange ? green ? maybe another...

good idea. I think I'll use this lib http://code.google.com/p/flot/, if you don't have any better suggestion.

We've been running with this patch at Twitter since February and we're getting kmem metrics. The mentioned bug is interesting, we've only been running with 4.9 and later.

That sounds reasonable. I'll get to update the review with this. Should I move the review to reviewboard or keep iterating here ?