Florent Chatterji
Florent Chatterji
I added a PR with some tests. I think I could go further and add more tests, but this seems to be a good start
hi @cielf , no unfortunately its tests regularly failing, because of changes made here. i'll try to debug in the next few days
@dorner ok, what I did was prevent importing when there are already items in the inventory. So whenever an import is made, it is made on an empty inventory. So...
ok gotcha, the PR is ready for review
Hey, so i adjusted the PR for a new review. As discussed on slack, i left the inventory already has items error.
@dorner No worries, i understand. So what remains to be done on this ticket? Just removing the split_difference?
Hey, i can work on this
@compwron sorry had to close the previous PR and open this one (the other one was created from my main branch by mistake)